Skip to content

Fix the initialization order in GenericScheduledExecutorService #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2015
Merged

Fix the initialization order in GenericScheduledExecutorService #3588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/main/java/rx/internal/schedulers/GenericScheduledExecutorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,18 @@ public final class GenericScheduledExecutorService implements SchedulerLifecycle

private static final String THREAD_NAME_PREFIX = "RxScheduledExecutorPool-";
private static final RxThreadFactory THREAD_FACTORY = new RxThreadFactory(THREAD_NAME_PREFIX);

/* Schedulers needs acces to this in order to work with the lifecycle. */
public final static GenericScheduledExecutorService INSTANCE = new GenericScheduledExecutorService();

private final AtomicReference<ScheduledExecutorService> executor;

static final ScheduledExecutorService NONE;

private static final ScheduledExecutorService NONE;
static {
NONE = Executors.newScheduledThreadPool(0);
NONE.shutdownNow();
}

/* Schedulers needs acces to this in order to work with the lifecycle. */
public final static GenericScheduledExecutorService INSTANCE = new GenericScheduledExecutorService();

private final AtomicReference<ScheduledExecutorService> executor;

private GenericScheduledExecutorService() {
executor = new AtomicReference<ScheduledExecutorService>(NONE);
start();
Expand Down