1.x: Test adjustments to reduce problems when tests run on Android #3504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thread.currentThread().setUncaughtExceptionHandler(new UncaughtExceptionHandler() { | ||
| @Override | ||
| public void uncaughtException(Thread t, Throwable e) { | ||
| // ignoring |
There was a problem hiding this comment.
Let's assert that UncaughtExceptionHandler received throwable?
akarnokd
force-pushed
the
AndroidTestFixes
branch
from
05e8911 to
194a3b1
Compare
|
Adjusted tests as requested. |
|
@akarnokd now |
akarnokd
force-pushed
the
AndroidTestFixes
branch
from
194a3b1 to
2649b68
Compare
|
I've increased the wait to 1s, let's hope that's enough waiting time. Travis tends to have some strange thread delays. |
|
👍 |
|
Can we merge this, please? Required for running tests on Android during the CI #3503. |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 22, 2016
1.x: Test adjustments to reduce problems when tests run on Android
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes may help in reducing problems when the tests are run on an Android emulation: