Use explicit versioning for gradle-rxjava-project-plugin #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious to the delay on this PR, seems straightforward. @JakeWarton I'm going to quote you here from your gist :
@quidryan Thought I'd check with you here seeing as you have done a lot of gradle build work with RxJava. |
Just me.
We avoid them in actual project dependencies (of which we have none), but for the Gradle project plugins itself we were okay with it as we controlled both of them and it simplified build fixes. I'm okay either way. Have you run into issues with the plugin? |
benjchristensen
added a commit
that referenced
this pull request
May 13, 2015
Use explicit versioning for gradle-rxjava-project-plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a release is created the tagged version should build deterministically at any time. The wildcard dependency on
gradle-rxjava-project-plugininbuild.gradlemeans this will not be the case. This PR sets the version at 2.2.3 (the latest on Maven Central).