Skip to content

Update to Swift 5 and Fix Carthage #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2019
Merged

Conversation

djtech42
Copy link
Member

  • update dependencies (ReSwift 4.1.1, Nimble 8.0.1, Quick 2.1.0)
  • use Swift 5 as the language version
  • use hash(into:) instead of deprecated hashValue
  • set version to 0.6.1
  • set as library instead of executable in Package.swift
  • update Travis to use Xcode 10.2 image and iOS/tvOS 12.2 SDKs

@codecov-io
Copy link

Codecov Report

Merging #115 into master will increase coverage by 11.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #115       +/-   ##
==========================================
+ Coverage   74.31%   85.5%   +11.18%     
==========================================
  Files           5       5               
  Lines         109     200       +91     
==========================================
+ Hits           81     171       +90     
- Misses         28      29        +1
Impacted Files Coverage Δ
ReSwiftRouter/NavigationState.swift 100% <100%> (ø) ⬆️
ReSwiftRouter/NavigationReducer.swift 100% <0%> (ø) ⬆️
ReSwiftRouter/Router.swift 84.66% <0%> (+13.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1777395...563cbe7. Read the comment docs.

@DivineDominion DivineDominion merged commit e1d468d into ReSwift:master May 20, 2019
@DivineDominion
Copy link
Contributor

Great stuff, thanks @djtech42!

@DivineDominion DivineDominion mentioned this pull request May 20, 2019
6 tasks
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@1777395). Learn more about missing BASE report.
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #115   +/-   ##
=========================================
  Coverage          ?   85.50%           
=========================================
  Files             ?        5           
  Lines             ?      200           
  Branches          ?        0           
=========================================
  Hits              ?      171           
  Misses            ?       29           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants