Skip to content

Conversation

@BenHenning
Copy link
Collaborator

@BenHenning BenHenning commented May 2, 2025

The basics

The details

Resolves

This fixes the ongoing CI failure for the conventional auto-labeling.

Proposed Changes

This fixes the permissions in a way that should work. It may be the case that 'issues' only needs to be 'read' but I'm basically just copying what's done in https://github.com/GoogleCloudPlatform/developer-journey-app/blob/main/.github/workflows/auto-label.yml since it's working for them.

Reason for Changes

We want this workflow working--it's preferable to avoid getting used to a failing CI workflow (ideally every PR has zero CI failures).

As for the specific changes, note that the check will still fail in this PR. Similar to #8811, it's not expected that the CI workflow will pass in this PR until the change is checked in since the workflow uses 'pull_request_target'. While I haven't verified this change directly, I'm fairly confident it will work given the project linked above and our successes with fixing the auto assigner workflow.

Finally, the 'contents: read' bit is unnecessary since that's the default permission for GITHUB_TOKEN per https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token.

Edit: It seems that the check actually is passing with these changes--that's a bit surprising to me.

Test Coverage

N/A

Documentation

N/A

Additional Information

None.

@BenHenning BenHenning requested a review from a team as a code owner May 2, 2025 01:07
@BenHenning BenHenning requested a review from cpcallen May 2, 2025 01:07
@github-actions github-actions bot added the PR: fix Fixes a bug label May 2, 2025
@BenHenning
Copy link
Collaborator Author

Note that I'm enabling auto-merge here since it would be ideal to get this checked in sooner and there's probably no need to wait for me to merge it myself (unless of course there are problems to address later).

@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 2, 2025
@BenHenning BenHenning enabled auto-merge (squash) May 2, 2025 01:09
@github-actions github-actions bot added the PR: fix Fixes a bug label May 2, 2025
@BenHenning BenHenning disabled auto-merge May 2, 2025 01:09
@BenHenning BenHenning enabled auto-merge (squash) May 2, 2025 01:09
@BenHenning BenHenning disabled auto-merge May 2, 2025 01:10
@BenHenning BenHenning enabled auto-merge (squash) May 2, 2025 01:11
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 2, 2025
@BenHenning BenHenning merged commit 778b7d5 into RaspberryPiFoundation:develop May 2, 2025
15 checks passed
@BenHenning BenHenning deleted the fix-auto-labeling branch May 2, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants