fix: remove black outline on focused items #8951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
BenHenning
and removed request for
RoboErikG
BenHenning
approved these changes
May 1, 2025
rachel-fenichel
merged commit 45c1426
into
RaspberryPiFoundation:rc/v12.0.0
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes an issue found while working on #8950
The black outline around the selected block should not be visible when the keyboard nav plugin is not involved. Also true for the workspace, flyout, and toolbox.
Proposed Changes
Add CSS that sets outline width to zero on the focus items.
Reason for Changes
Fix visual regression.
Test Coverage
Tested by clicking around in the playground to change focus, including
Additional Information
CSS provided by @BenHenning