fix: Fix bug that caused flyout items under the mouse to be selected without movement. #8900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without movement.
BenHenning
approved these changes
Apr 17, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! No concerns here.
gonfunko
merged commit 5b103e1
into
RaspberryPiFoundation:rc/v12.0.0
8 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#216
Proposed Changes
This PR updates the flyouts to select items on
pointermoverather thanpointerenter. This resolves an issue where, when using keyboard navigation, flyout items that happened to appear under the mouse when the flyout was opened via the keyboard would appear selected. This resulted in a confusing behavior where there could be two selections: the cursor, and the block incidentally under the mouse. Now, blocks will not be selected/highlighted unless the mouse is actually moved.