fix: Fix keyboard-driven menu scrolling. #8881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
changed the title
rachel-fenichel
approved these changes
Apr 14, 2025
gonfunko
merged commit e45471d
into
RaspberryPiFoundation:rc/v12.0.0
8 of 14 checks passed
Collaborator
|
@riknoll It's worth highlighting that this fix impacts MakeCode where some of these changes will need to be copied across or negated. We've quickly patched this, but I'm sure there are better approaches. Changes will be required when upgrading from v12.0.0-beta.3 to v12.0.0-beta4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8880
Proposed Changes
This PR fixes scrolling of contextual menus using the arrow keys. It scrolls the menu item relative to the menu, whereas previously it was scrolling the menu item relative to the menu's parent element. This worked for dropdowns (which have an intermediate div between the menu and the container), but not for contextual menus, where the menu element lived directly in the WidgetDiv. This change broke keyboard scrolling of dropdown menus, but I adjusted their styling to work similarly to context menus. This in turn allowed for the removal of a manual scroll to move the selected dropdown menu item into view, which is now handled automatically by the menu.