feat: add getSearchRadius to BlockDragStrategy #8871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
BenHenning and
maribethb
and removed request for
maribethb
BenHenning
approved these changes
Apr 7, 2025
Collaborator
|
Makes sense to me--no concerns for getting this into v12. |
rachel-fenichel
merged commit 76b02de
into
RaspberryPiFoundation:rc/v12.0.0
8 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8869
Proposed Changes
Create a protected helper function that can be overridden.
Reason for Changes
Keyboard drags sometimes search for the nearest compatible block on a workspace, which means an effective radius of Infinity.
Test Coverage
No current change to functionality.
Documentation
Additional Information
I'd like to put this into the next v12 beta release.