Skip to content

Conversation

@RoboErikG
Copy link
Contributor

@RoboErikG RoboErikG commented Apr 2, 2025

The basics

The details

Resolves

Fixes #6020

Proposed Changes

  • Clears the collapsed block warning message when a block is expanded.
  • When collapsing, checks if any children have a warning and if so adds the collapsed warnings warning.

Reason for Changes

The collapsed block warning message was set if any block in a collapsed stack added a warning, but wasn't added if there already was a warning and was never removed making it sticky on the parent even after expanding and deleting the block with the warning.

Test Coverage

Documentation

Additional Information

@RoboErikG RoboErikG requested a review from a team as a code owner April 2, 2025 16:47
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but please check if we have any related tests and add one for this case if possible.

@RoboErikG
Copy link
Contributor Author

Added tests, which required fixing the other bug where warning icons didn't show up right away when a block is collapsed.

Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change then lgtm. I'll manually add the pr: fix label in a sec.

@rachel-fenichel rachel-fenichel added the PR: fix Fixes a bug label Apr 21, 2025
@RoboErikG RoboErikG merged commit b3bce67 into RaspberryPiFoundation:develop Apr 21, 2025
7 checks passed
@RoboErikG RoboErikG deleted the collapsed-warning branch April 21, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings for collapsed blocks does not update

2 participants