Feature: Add a dropdown options setter #8833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
reviewed
Mar 31, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @RoboErikG! Had some thoughts and suggestions, PTAL.
BenHenning
approved these changes
Apr 3, 2025
Collaborator
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks, LGTM @RoboErikG!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #1288
Proposed Changes
Adds a setOptions function to field_dropdown to allow changing the set of options or the generator for options after creation.
Reason for Changes
This makes it easier to define blocks with dynamic dropdowns in JSON.
Test Coverage
Added a test to verify the selected option is updated after changing the set of options.
Documentation
We should consider updating the dropdown field docs to include this as a simpler option for the JSON definitions.
Additional Information