fix: Fix bug that caused blocks dragged from non-primary flyouts to be misplaced. #8753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR fixes a bug in v12 that caused blocks dragged from non-primary flyouts (e.g. the trash) to be misaligned relative to the mouse. The block inflater was setting up click handlers with the flyout of the flyout workspace's target workspace (confusing, I know), on the assumption that that was the flyout in which the block was being inflated. This is not true though; the trash's flyout workspace's target workspace is the main workspace, and that workspace's flyout is the main toolbox flyout, not the trash flyout. This indirection was necessary because IFlyout passed in the flyout workspace to inflaters, so the flyout itself had to be derived when needed. This PR changes the interface to instead pass in the flyout itself (which has a getter for its workspace). This would be breaking, but v12 is still in beta.