fix: Correctly calculate the bounds of hat blocks. #8616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes gonfunko/scratch-blocks#201
Proposed Changes
This PR updates the calculation of the height of hats on blocks. Previously, the height of a hat was the value that was used for the Y position of points on an SVG curve. However, this is not the actual Y position of e.g. the apex of the curve, but rather the Y position of the control points used to define the Bézier curve, which is different from the actual max Y value of the curve itself; note the position of the lower control points relative to the bottom of the curve in the graphic here: https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths#b%C3%A9zier_curves.
Per https://stackoverflow.com/a/5327329, the height of the curve is 3/4 the Y position of the control points, at least in the simple situation we use for hats. As a result, before this change, the bounds of hat blocks were incorrect:
With this change, the bounds are as expected across all three built-in renderers:
