Skip to content

Conversation

@gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes #8540

Proposed Changes

This PR adds a new IFlyoutInflater interface that will be used to create and dispose of arbitrary elements that may live on a flyout's workspace. Future PRs will add concrete implementations and refactor the flyout to use them.

Reason for Changes

This will allow for developers to add additional, arbitrary types of elements to flyouts.

@gonfunko gonfunko requested a review from a team as a code owner September 19, 2024 17:30
@gonfunko gonfunko requested a review from cpcallen September 19, 2024 17:30
@github-actions github-actions bot added the PR: feature Adds a feature label Sep 19, 2024
@gonfunko
Copy link
Contributor Author

Note that the gapForElement method is an addition relative to Beka's design doc. This is needed because certain elements (in particular blocks) can specify a gap in their definition, which follows the element in question. The flyout, when parsing its contents, will first get the element, then request its desired gap.

@gonfunko gonfunko merged commit 6ec1bc5 into RaspberryPiFoundation:rc/v12.0.0 Sep 25, 2024
@gonfunko gonfunko deleted the iflyout-inflater branch September 25, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants