feat: added block's style as a CSS class to block's root SVG #8436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
suggested changes
Jul 30, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
One initial fix then I'll give it a more thorough check!
Contributor
Author
|
Hey @BeksOmega, I have done the needful. Kindly review. |
BeksOmega
suggested changes
Aug 5, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Looks great! Just one fix then should be good to go =)
core/block_svg.ts
Outdated
Comment on lines
1165
to
1167
| if (!this.svgGroup_) { | ||
| throw new Error('SVG group is not defined'); | ||
| } |
Contributor
There was a problem hiding this comment.
Can you remove this? The svgGroup_ is non-nullable.
BeksOmega
approved these changes
Aug 6, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Sweet once CI passes I'll get this merged =)
BeksOmega
changed the title
github-actions
bot
added
PR: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details :
Added the
blockStyleNameas a CSS class on the block. Also calleddom.removeClasswiththis.styleName_to remove any previous style.Fixes :
#8269