feat: add blocklyLabelField css class to label field
#8423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @BeksOmega Please review this !! |
Contributor
Author
|
Hey @gonfunko Please review this !! |
Contributor
Author
|
Hiya @BeksOmega @gonfunko I have made the required changes. Please review the changes and let me know ! |
BeksOmega
changed the title
blocklyLabelField css class to label field
BeksOmega
approved these changes
Jul 30, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks great thank you for the fixes! Once CI passes I'll get this merged =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes Issue #8315
Proposed Changes
This pull request adds a
blocklyLabelFieldCSS class to label fields in theFieldLabelclass by modifying theinitViewmethod to calldom.addClasswiththis.fieldGroup_andblocklyLabelField.Reason for Changes
This change helps in applying specific styles to label fields, allowing better customization and theming of Blockly components.
Test Coverage
I tested these changes manually by creating and manipulating label fields in the Blockly playground. Additionally, I verified that the
blocklyLabelFieldclass is applied correctly in different scenarios.Documentation
No additional documentation is needed for this PR.
Additional Information
No additional information.