blocklyShadow not set when using geras

[rpbourret]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

In the common version of PathObject.updateShadow_, PR 8336 adds a blocklyShadow class to shadow blocks and removes it from non-shadow blocks. The problem is that geras overrides updateShadow_ and does not call super.updateShadow_, so blocklyShadow is not set when using geras.

To fix this:

1. Call super.updateShadow_(shadow) from the first line of the geras version of updateShadow_.
2. Delete the calls to set the stroke and the fill on this.svgPath, as this is done in the super class.

We should also consider moving the test for this.style.colourSecondary from geras to the common version -- it seems that if this is a bug in one renderer, it is a bug in all of them. The same is true for the test in geras for this.style.colourTertiary in the geras version of applyColour_. However, this is a potentially breaking change, as null colours are currently tolerated by non-geras renderers, so we might need to understand the rationale for these tests before doing this. (These tests were added in PR 6451, but the reason given ("We like the build to build") is vague.)

Reproduction steps

Priority

Work effort: Trivial?
Impact: Developers cannot style shadow blocks using CSS when using geras.
Workaround: None known.

Stack trace

Screenshots

No response

Browsers

No response