Add support for application emojis #9891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCausc78
reviewed
Jul 19, 2024
seven7ty
approved these changes
Jul 20, 2024
SnowzNZ
approved these changes
Jul 29, 2024
DA-344
reviewed
Jul 29, 2024
Co-authored-by: DA344 <[email protected]>
DA-344
reviewed
Aug 8, 2024
Co-authored-by: DA344 <[email protected]>
Rapptz
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Looks okay.
I think this is still technically a breaking change on the Emoji.guild front because it'll do get_guild(0) which will return None. I suppose it can be okay to change the typing from Guild to Optional[Guild] as it is in the type hints in this extraordinary case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docs PR: discord/discord-api-docs#7010
Bikeshedding discussion: https://canary.discord.com/channels/336642139381301249/1263586512998764604
Checklist