-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add parameter type multi-list
#4886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
papaj-na-wrotkach
wants to merge
27
commits into
RSS-Bridge:master
Choose a base branch
from
papaj-na-wrotkach:feat/mult-list-parameter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−32
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
77c1c41
feat: add parameter type `multi-list`
papaj-na-wrotkach a6cd0b6
fix: fix parameter validation for arrays
papaj-na-wrotkach c4f1880
test: validate `BridgeCard::getListInput` method for `multi-list`
papaj-na-wrotkach d573a65
test: handle `multi-list` parameter type in `BridgeImplementationTest`
papaj-na-wrotkach b6cace4
test: add tests for `multi-list` parameter type in `ParameterValidato…
papaj-na-wrotkach 564420d
test: fix errors in tests
papaj-na-wrotkach 4ac27cd
fix: handle `defaultValue` properly for `multi-list`
papaj-na-wrotkach 6d2427d
fix: clarify the description in the docblock
papaj-na-wrotkach 044d896
style: add braces to comply with PSR-12
papaj-na-wrotkach f1b3392
fix(ui): make `multi-list` parameters displayed correctly
papaj-na-wrotkach ad1738b
fix: make backported array functions behave correctly
papaj-na-wrotkach d84f7f2
fix: validate the parameter type correctly
papaj-na-wrotkach 9b7cddf
fixup! fix: validate the parameter type correctly
papaj-na-wrotkach 79ceb94
fixup! fix(ui): make `multi-list` parameters displayed correctly
papaj-na-wrotkach 1f871e2
fixup! style: add braces to comply with PSR-12
papaj-na-wrotkach 14f6329
Merge branch 'master' into feat/mult-list-parameter
papaj-na-wrotkach 4843b0b
style: fix line length
papaj-na-wrotkach 735b5d5
feat: support for scalar `defaultValue` for `multi-list`
papaj-na-wrotkach 4c41ad5
fixup! feat: support for scalar `defaultValue` for `multi-list`
papaj-na-wrotkach b2ebe01
fix: detect empty values inside `getListInput`
papaj-na-wrotkach 8b7bc26
Merge branch 'RSS-Bridge:master' into feat/mult-list-parameter
papaj-na-wrotkach 7a4b7bf
Merge branch 'master' into feat/mult-list-parameter
papaj-na-wrotkach ea6ffcd
style: fix line exceeding character limit
papaj-na-wrotkach 177ae0c
fix: properly handle empty default value
papaj-na-wrotkach e784e32
fix: do not access `defaultValue` if there are no values
papaj-na-wrotkach f57ce19
test: add test for multiple default values
papaj-na-wrotkach 3de2325
Merge branch 'master' into feat/mult-list-parameter
papaj-na-wrotkach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.