Skip to content

[SpottschauBridge] Rewrite of the Spottschau Bridge#4874

Open
mibe wants to merge 4 commits intoRSS-Bridge:masterfrom
mibe:spottschau
Open

[SpottschauBridge] Rewrite of the Spottschau Bridge#4874
mibe wants to merge 4 commits intoRSS-Bridge:masterfrom
mibe:spottschau

Conversation

@mibe
Copy link
Contributor

@mibe mibe commented Jan 26, 2026

This is basically a rewrite of the Spottschau bridge:

  • A new strip is published once per week, so a cache timout of 1 h is overkill. Using 24 h now.
  • The <h2> element is empty since at least 2022, so title is empty since then. Same with the <img alt> attribute.
  • An empty title means no timestamp. I was getting a deprecated warning caused by providing null to a time function, probably somewhere downstream.
  • Use defaultLinkTo() helper instead of urljoin'ing.

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Pull request artifacts

Bridge Context Status
Spottschau 1 untitled (current) ✔️
Spottschau 1 untitled (pr) ✔️

last change: Tuesday 2026-02-03 23:00:25

@dvikan
Copy link
Contributor

dvikan commented Jan 29, 2026

please dont use the or operator,

also that function never returns a falsy value so its pointless

@mibe
Copy link
Contributor Author

mibe commented Feb 3, 2026

@dvikan You are correct, thank you for noticing.

I got fooled by the @return tag in the DocBlock of the getSimpleHTMLDOMCached function. It states false|simple_html_dom Contents as simplehtmldom object. The falseis wrong, the function always returns an object. What do you think, should I open a PR to correct the tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants