[rocprofiler-sdk] Enable region argument annotation in perfetto output trace

[mcao59]

Motivation

This PR enables function argument annotation in Perfetto with --annotate-args.
Without info like event ID arg value, it may be hard to follow event dependencies and debug HIP event synchronization.
The goal is disambiguating waits across multiple events/streams: when a stream waits on different events originating from different streams, having the event ID allows them to correlate hipStreamWaitEvent with the corresponding hipEventRecord calls and identify which event (and thus which upstream stream/work) is actually blocking execution.

With this PR: When --annotate-args (introduced in #340) is used in rocpd to perfetto conversion, the function arguments get annotated

Technical Details

• Enabling arg annotation in perfetto.cpp:
• Tests
  • added separate execution and validation tests for perfetto output converted with --annotate-args
  • Test checks for annotations. Test will fail if expected annotations are not found

JIRA ID

Resolves AIPROFSDK-195

Test Plan

Local testing:

$ pytest -s validate_annotations.py   --pftrace-input=rocpd-output-data-annotations/out_results.pftrace 
===== test session starts =====
platform linux -- Python 3.10.12, pytest-9.0.2, pluggy-1.6.0
rootdir: /home/mcao/my_proj/rocm-systems/projects/rocprofiler-sdk/tests/rocprofv3/rocpd
configfile: pytest.ini
plugins: metadata-3.1.1, json-report-1.5.0, allure-pytest-2.15.3, rerunfailures-16.1
collected 1 item                                                                                                                                                                                                                                                     

../../../../projects/rocprofiler-sdk/tests/rocprofv3/rocpd/validate_annotations.py 
Validation passed: Found 14019 argument annotations
  - 11 unique API calls annotated
  - 1 categories: ['hip_api']
  - 12 unique argument types
  - Sample argument names: ['debug.count', 'debug.deviceId', 'debug.stream', 'debug.event', 'debug.function_address', 'debug.numBlocks', 'debug.dimBlocks', 'debug.args', 'debug.sharedMemBytes', 'debug.ms']
.

====== PASSES =====
 ======slowest 20 durations =========
3.25s setup    validate_annotations.py::test_arg_annotations
2.96s call     validate_annotations.py::test_arg_annotations

(1 durations < 0.005s hidden.  Use -vv to show these durations.)
===== short test summary info =====
PASSED ../../../../projects/rocprofiler-sdk/tests/rocprofv3/rocpd/validate_annotations.py::test_arg_annotations
====== 1 passed in 6.21s =====

Test Result

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[yhuiYH]

LGTM. CI tests are queued because the pool has been re-purposed. But it was passing before and I checked the tests locally, seems to be passing.

[jrmadsen]

Why not just annotate all the rocpd_args associated with the event_id? Wouldn't this include the event handle?

[mcao59]

Why not just annotate all the rocpd_args associated with the event_id? Wouldn't this include the event handle?

@jrmadsen sure, please see enable arg annotation for all instead of only event ID. Updated tests as well to validate --annotate-args