Adding more unit tests to reach 80% #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Update continuous_integration.yml * Updates from editor [ROCm/rocprofiler-sdk commit: acab627]
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 10, 2025
Change-Id: Id3fff8f2722d521071ef0ff71b09fc365ef6fa82
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
Change-Id: Id3fff8f2722d521071ef0ff71b09fc365ef6fa82 [ROCm/clr commit: 588cf0f]
bing-ma
reviewed
Sep 3, 2025
bing-ma
reviewed
Sep 3, 2025
bing-ma
reviewed
Sep 3, 2025
bing-ma
approved these changes
Sep 3, 2025
Contributor
bing-ma
left a comment
bing-ma
left a comment
There was a problem hiding this comment.
I only reviewed SPM tests and left some comments. These tests are good starting points for spm_builder code coverage, and we can gradually improve the test quality.
ammarwa
approved these changes
Sep 4, 2025
bgopesh
deleted the
import/develop/ROCm_aqlprofile/gobhardw_code-cov
branch
systems-assistant bot
pushed a commit
to ROCm/aqlprofile
that referenced
this pull request
Sep 11, 2025
* Adding more unit tests to reach 80% * Adding pmc and command builder tests * tests for spm, sqtt and trace config * removing non-existent struct members from test * Adding logger tests * aqlprofile_v2 tests * spm builder tests * Addressed feedback [rocm-systems] ROCm/rocm-systems#177 (commit 5b9ba5b)
rahulc-gh
added a commit
that referenced
this pull request
Sep 11, 2025
This reverts commit 5b9ba5b.
sauverma93
pushed a commit
that referenced
this pull request
Sep 26, 2025
* Adding more unit tests to reach 80% * Adding pmc and command builder tests * tests for spm, sqtt and trace config * removing non-existent struct members from test * Adding logger tests * aqlprofile_v2 tests * spm builder tests * Addressed feedback --------- Co-authored-by: gobhardw <[email protected]> Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
ryang-amd
pushed a commit
that referenced
this pull request
Nov 7, 2025
* Adding more unit tests to reach 80% * Adding pmc and command builder tests * tests for spm, sqtt and trace config * removing non-existent struct members from test * Adding logger tests * aqlprofile_v2 tests * spm builder tests * Addressed feedback --------- Co-authored-by: gobhardw <[email protected]> Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
- Updates:
- Adding the following metrics to allow new calculations for violation status:
- Per XCP metrics gfx_below_host_limit_ppt_acc
- Per XCP metrics gfx_below_host_limit_thm_acc
- Per XCP metrics gfx_low_utilization_acc
- Per XCP metrics gfx_below_host_limit_total_acc
- Increasing available JPEG engines to 40. Current ASICs may not support all 40. These will be indicated as UINT16_MAX or N/A in CLI.
Signed-off-by: Juan Castillo <[email protected]>
Co-authored-by: Charis Poag <[email protected]>
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
- Updates:
- Adding the following metrics to allow new calculations for violation status:
- Per XCP metrics gfx_below_host_limit_ppt_acc
- Per XCP metrics gfx_below_host_limit_thm_acc
- Per XCP metrics gfx_low_utilization_acc
- Per XCP metrics gfx_below_host_limit_total_acc
- Increasing available JPEG engines to 40. Current ASICs may not support all 40. These will be indicated as UINT16_MAX or N/A in CLI.
Signed-off-by: Juan Castillo <[email protected]>
Co-authored-by: Charis Poag <[email protected]>
[ROCm/amdsmi commit: 7c882b2]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
- Updates:
- Adding the following metrics to allow new calculations for violation status:
- Per XCP metrics gfx_below_host_limit_ppt_acc
- Per XCP metrics gfx_below_host_limit_thm_acc
- Per XCP metrics gfx_low_utilization_acc
- Per XCP metrics gfx_below_host_limit_total_acc
- Increasing available JPEG engines to 40. Current ASICs may not support all 40. These will be indicated as UINT16_MAX or N/A in CLI.
Signed-off-by: Juan Castillo <[email protected]>
Co-authored-by: Charis Poag <[email protected]>
[ROCm/amdsmi commit: 7c882b2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔁 Imported from ROCm/aqlprofile#19
🧑💻 Originally authored by @rocm-devops