Skip to content

Conversation

dorde-antic
Copy link
Contributor

@dorde-antic dorde-antic commented Mar 13, 2025

Required for #1762

@dorde-antic dorde-antic requested a review from causten as a code owner March 13, 2025 18:50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think typically requirements.txt is in the root folder of the project

Copy link
Contributor

@dhernandez0 dhernandez0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer requirements.txt to be in the root because most projects do that. Approving anyway

@dorde-antic dorde-antic merged commit 6e89f22 into develop Mar 14, 2025
11 of 23 checks passed
@dorde-antic dorde-antic deleted the requirements branch March 14, 2025 19:07
umangyadav pushed a commit that referenced this pull request May 6, 2025
* Add requirements.txt file and modify Dockerfile for installing hip-python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants