Skip to content

Get CI working for 0.6.0 branch #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Get CI working for 0.6.0 branch #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb0bc23
Account for versioned clang binaries
charleshofer Apr 10, 2025
4ac6032
Remove ROCm 6.2 build
charleshofer May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rocm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
python: ["3.10.13"]
rocm: ["6.2.4", "6.3.3"]
rocm: ["6.3.3"]
env:
BASE_IMAGE: "ubuntu:22.04"
TEST_IMAGE: ubuntu-jax-${{ github.run_id }}_${{ github.run_number }}_${{ github.run_attempt }}
Expand Down
9 changes: 7 additions & 2 deletions build/tools/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,13 @@ def get_clangpp_path(clang_path):
clang_path = pathlib.Path(clang_path)
clang_exec_name = clang_path.name
clangpp_exec_name = clang_exec_name
if "clang++" not in clang_exec_name:
clangpp_exec_name = clang_exec_name.replace("clang", "clang++")
clangpp_path = clang_path.parent / clang_exec_name
# Try and match what the user passed in (either clang-18 or clang)
if "clang++" not in clangpp_exec_name:
clangpp_exec_name = clangpp_exec_name.replace("clang", "clang++")
clangpp_path = clang_path.parent / clangpp_exec_name
if not clangpp_path.exists():
clangpp_exec_name = "clang++"
clangpp_path = clang_path.parent / clangpp_exec_name
if not clangpp_path.exists():
raise FileNotFoundError(
Expand Down
Loading