[AOMP] Add shellcheck workflow #1435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an initial (crude) shellcheck workflow. This can be refined much more. - Use shellcheck directly from maintainer github. - Filter which files to check. - Come up with set of guidelines / rules for errs/warns.
Use find + xargs to make the job fail in case shellcheck found issues.
|
This depends on #1252 and makes only sense once that has landed. |
dpalermo
requested changes
May 16, 2025
dpalermo
requested changes
May 22, 2025
dpalermo
approved these changes
Jun 2, 2025
|
I think we want to wait for #1463 to land and then use this wrapper instead of plain |
|
As it is, the aomp-shellcheck script automatically modifies the files given as arguments in some circumstances (i.e. if they have failing checks in the "patchable" check list), which is probably not desirable for the GitHub workflow case. |
|
Good point. Should there be a |
|
I think so, something like that. |
|
I've added a new --check-only option in the version up on #1463 now. |
e-kwsm
suggested changes
Jun 4, 2025
|
|
||
| - name: Run shellcheck | ||
| run: | | ||
| find . -name "*.sh" | xargs shellcheck -S info {} \; |
There was a problem hiding this comment.
The syntax is wrong, which must be
Suggested change
| find . -name "*.sh" | xargs shellcheck -S info {} \; | |
| find . -name "*.sh" -exec shellcheck -S info {} + |
or
Suggested change
| find . -name "*.sh" | xargs shellcheck -S info {} \; | |
| find . -name "*.sh" | xargs shellcheck -S info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.