[COMGR] Fixes for HIP PCH #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConvAsmImplicitGemmV4R1DynamicWrw
…handle_test (leftovers)
…UG_COMGR_HIP_PCH_DISABLE -> ...ENFORCE
…reduction_operator.hpp (fixes reduce_test)
…disabled. Rename W/A macro.
atamazov
requested review from
JehandadKhan,
qianfengz,
shaojiewang and
daniellowell
|
@fronteer @shaojiewang @JehandadKhan You are all assigned to review this urgent PR, please do so. |
daniellowell
reviewed
Dec 1, 2020
| return HIP_SUPPORTS_PCH; | ||
| } | ||
|
|
||
| static std::string GetPchEnableStatus() |
There was a problem hiding this comment.
I feel like this could be useful elsewhere and not just logging.
There was a problem hiding this comment.
Only here so far. Any ideas?
Codecov Report
@@ Coverage Diff @@
## develop #627 +/- ##
===========================================
- Coverage 53.02% 52.11% -0.92%
===========================================
Files 297 297
Lines 45814 45814
===========================================
- Hits 24294 23877 -417
- Misses 21520 21937 +417
Continue to review full report at Codecov.
|
JehandadKhan
previously approved these changes
Dec 2, 2020
|
Description updated. |
daniellowell
approved these changes
Dec 5, 2020
jeffdaily
pushed a commit
to jeffdaily/MIOpen
that referenced
this pull request
Jan 6, 2021
* comgr-hip-pch-fix(01) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in handle_test * comgr-hip-pch-fix(02) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in ConvAsmImplicitGemmV4R1DynamicWrw * comgr-hip-pch-fix(03) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in handle_test (leftovers) * comgr-hip-pch-fix(04) Add MIOPEN_DEBUG_COMGR_HIP_PCH_DISABLE * comgr-hip-pch-fix(05) Allow forced enabled & disabled PCH. MIOPEN_DEBUG_COMGR_HIP_PCH_DISABLE -> ...ENFORCE * comgr-hip-pch-fix(06) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in reduction_operator.hpp (fixes reduce_test) * comgr-hip-pch-fix(07) Fix incorrect #include in kernel source * comgr-hip-pch-fix(08) Temporary W/A for handle_test * comgr-hip-pch-fix(09) Disable W/A for handle_test * comgr-hip-pch-fix(10) handle_test: Fix for the case when HIP kernels disabled. Rename W/A macro. * comgr-hip-pch-fix(11) Automatically disable W/A in handle test after ROCm 3.10 * comgr-hip-pch-fix(13) W/A: Disable HIP PCH for ROCm <= 3.9.x
daniellowell
pushed a commit
that referenced
this pull request
Jan 8, 2021
* comgr-hip-pch-fix(01) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in handle_test * comgr-hip-pch-fix(02) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in ConvAsmImplicitGemmV4R1DynamicWrw * comgr-hip-pch-fix(03) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in handle_test (leftovers) * comgr-hip-pch-fix(04) Add MIOPEN_DEBUG_COMGR_HIP_PCH_DISABLE * comgr-hip-pch-fix(05) Allow forced enabled & disabled PCH. MIOPEN_DEBUG_COMGR_HIP_PCH_DISABLE -> ...ENFORCE * comgr-hip-pch-fix(06) Observe MIOPEN_DONT_USE_HIP_RUNTIME_HEADERS in reduction_operator.hpp (fixes reduce_test) * comgr-hip-pch-fix(07) Fix incorrect #include in kernel source * comgr-hip-pch-fix(08) Temporary W/A for handle_test * comgr-hip-pch-fix(09) Disable W/A for handle_test * comgr-hip-pch-fix(10) handle_test: Fix for the case when HIP kernels disabled. Rename W/A macro. * comgr-hip-pch-fix(11) Automatically disable W/A in handle test after ROCm 3.10 * comgr-hip-pch-fix(13) W/A: Disable HIP PCH for ROCm <= 3.9.x
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues related to SWDEV-257056:
MIOPEN_DONT_USE_HIP_RUNTIME_HEADERSinhandle_test.MIOPEN_DONT_USE_HIP_RUNTIME_HEADERSin reduction_operator.hpp (fixesreduce_test).MIOPEN_DONT_USE_HIP_RUNTIME_HEADERSin ConvAsmImplicitGemmV4R1DynamicWrw.handle_testfor the case when HIP kernels disabled.#includein kernel source.handle_testfor macros missing from HIP PCH in ROCm, 3.10 RC3WORKAROUND_SWDEV_257056_PCH_MISSING_MACROS.MIOPEN_DEBUG_COMGR_HIP_PCH_ENFORCEthat allows overriding of HIP PCH feature auto-detection.WORKAROUND_SWDEV_257056_PCH_INCORRECTLY_REPORTED.