Skip to content

Conversation

AnzhongHuang
Copy link
Contributor

Implemented the functionality to print the version of the AMDGPU kernel driver, the output consistency with: rocminfo's ROCk module version and rocm-smi --showdriverversion

And modified from OpDriver to MIOpenDriver

Proposed changes

Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • [ x] I have added automated tests relevant to the introduced functionality
  • I have sufficient test coverage for the changes, and code coverage hasn't decreased as a result of my PR
  • [ x] I have ran the tests, and they are all passing locally
  • I have added relevant documentation for the changes
  • I have removed the stale documentation which is no longer relevant after this pull request
  • [ x] I have ran make format & make check_format to ensure the changes have been formatted

Implemented the functionality to print the version of the AMDGPU kernel
driver, the output consistency with: rocminfo's ROCk module version and
rocm-smi --showdriverversion

And modified from OpDriver to MIOpenDriver
Copy link
Contributor

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM needs to pass CI, and windows build though.

Edit: Windows break seems to be unrelated to these changes.

Changed MIOpenDriver to MIOpen Driver
@amd-hsivasun
Copy link

Imported to ROCm/rocm-libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants