-
Notifications
You must be signed in to change notification settings - Fork 267
default paths to user and system db files on Windows #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5aceea7
default paths to suer and system db files on Windows
apwojcik 6dd8386
Merge branch 'develop' into database_support
apwojcik cb94e3f
Merge branch 'develop' into database_support
apwojcik e587889
Merge branch 'develop' into database_support
junliume 5461cef
fix tiny clang-format issue
junliume 77502c5
incorporate feedback from the review
apwojcik 68531ff
Merge branch 'develop' into database_support
apwojcik f8bc273
Merge branch 'develop' into database_support
apwojcik 606e09f
Merge branch 'develop' into database_support
junliume 7150675
Merge branch 'develop' into database_support
apwojcik 7dbd6a6
incorporate review feedback
apwojcik 06e6ba4
change HOME to USERPROFILE on Windows
apwojcik 053d80e
Merge branch 'develop' into database_support
apwojcik 626b88c
Merge branch 'develop' into database_support
apwojcik 7b1cf24
fix GetEnvironmentVariable
apwojcik 3ec3c81
Merge branch 'develop' into database_support
CAHEK7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it duplicates functionality of
<miopen/env.hpp>
.Can you consider using it, or can you propose how it can be improved to fit windows functionality?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apwojcik could you resolve this question before merging this PR?
It might not be a simple task so we can consider it as a future improvement instead.