MIOpenDriver gemm is broken and MIOpenDriver gemmfp16 is disabled without a reason

[AngryLoki]

Hi,

While testing build result of MIOpen 5.7.1 ebuild, I noticed that MIOpenDriver gemm fails in https://github.com/ROCmSoftwarePlatform/MIOpen/blob/rocm-5.7.1/src/gemm_v2.cpp#L672 after falling through switch above it with uninitialized gemm_desc.dataType.

Additionally I noticed that GemmDriver also works fine with float16. It looks like gemmfp16 flag was commented out since initial commit.

Here is the fix I've checked AngryLoki@717861b
Feel free to apply it as is or partially up to your decision.

[atamazov]

@AngryLoki Thanks for the proposed fix. Would you like to contribute to MIOpen yourself or would you like us to use your code and create a PR?

/cc @junliume

[AngryLoki]

@atamazov , could you do it, please? Maybe there is a better way to convert template type to miopen-type (also I forgot to remove // TODO half is not supported in gemm in main.cpp...)

[atamazov]

@AngryLoki I see, Ok. How urgent and important is this for you?

[AngryLoki]

@atamazov , not urgent, I will add a patch to 5.7.1 ebuild and just would like to see this patch eventually removed.

[CAHEK7]

@AngryLoki, have you tried to run gemmfp16 with verification (-V 1)?

[atamazov]

@CAHEK7 I would expect gemmfp16 to pass validation even without #2558 but only if GEMM problem under test is very small.