fix(extensions): support non-GitHub git URLs for extension installation#2539
Open
d191 wants to merge 1 commit intoQwenLM:mainfrom
Open
fix(extensions): support non-GitHub git URLs for extension installation#2539d191 wants to merge 1 commit intoQwenLM:mainfrom
d191 wants to merge 1 commit intoQwenLM:mainfrom
Conversation
Fixes extension installation from local domain git servers (GitLab, Bitbucket, etc.) by catching errors from parseGitHubRepoForReleases and falling back to use the source URL directly. - Add unit test for non-GitHub git URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes extension installation from local domain git servers (GitLab, Bitbucket, etc.) by catching errors from parseGitHubRepoForReleases and falling back to use the source URL directly.
Dive Deeper
When installing an extension from a self-hosted git server (e.g., https://gitlab.company.com/team/my-extension), the installation failed after user confirmation with:
The root cause was in packages/core/src/extension/extensionManager.ts - the getExtensionId function unconditionally called parseGitHubRepoForReleases() which only supports GitHub URLs.
Solution: Wrapped the call in try-catch. If parsing fails (non-GitHub URL), use the source URL as-is for generating the extension ID - same behavior as local type installations.
Reviewer Test Plan
qwen extensions install https://gitlab.company.com/team/test-extension
Testing Matrix
Linked issues / bugs
Fixes #2538