triage: silent-rerun notification should treat a bot-initiated close as a terminal action

[yiliang114]

Summary

Stage 1-pre's duplicate-close exit is the first terminal action in triage that leaves no PR review — and the Notify silent triage re-run step in .github/workflows/qwen-triage.yml is built on the review list alone (it checks HAS_REVIEW/STANDING and nothing else). Driving the extracted step against a stubbed gh in the close-exit state, it:

• POSTs the stage=rerun-summary comment ("Triage re-run completed without a new review … If this re-run was meant to review or approve, it did not") on the PR the same run just closed with an explanatory duplicate comment — self-contradictory within one timeline;
• emits ::warning title=Triage re-run left no bot review, dispatching a human to a correctly-handled run.

The base skill has other review-less terminal shapes (the deferred approve-on-green path, Stage 1b's re-run escalation), but none actively closes the PR and then announces on it that the re-run did nothing.

Proposed scope

Treat a bot-initiated close during the run as a terminal action before warning: fetch gh pr view "$NUMBER" --repo "$REPO" --json state,closedAt and exit quietly (or post an adapted note) when the PR closed at/after the trigger; alternatively detect a stage=1-pre bot comment created after the trigger. The suite already pins this step ("notifies the author when a manual triage re-run posts no review") — an assertion covering the close-exit exemption should go red if removed.

Source

Review thread PRRT_kwDOPB-92c6c3VLs on #10292 (Stage 1-pre spec review). Deferred from that PR because it touches qwen-triage.yml, outside that PR's diff.

[qwen-code-ci-bot]

✅ Qwen Triage finished — view run. See the stage comments in this thread for the result.

✅ Qwen Triage 已完成 —— 查看运行。结果见本线程中的各阶段评论。

[qwen-code-ci-bot]

Triage

• Type: bug
• Labels: type/bug, category/development, scope/ci-cd, priority/P2
• Next: make the Notify silent triage re-run step close-aware; the check is shape-agnostic and can land ahead of feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292

Analysis

• Reproduced: confirmed statically (unattended CI does not execute workflow code; no live reproduction run). In .github/workflows/qwen-triage.yml, the Notify silent triage re-run step decides from the review list alone — HAS_REVIEW (any bot review since the trigger comment) and STANDING (the bot's review on the current head). Nothing reads the PR's own state/closedAt.
• Latent until feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292 lands: on main today every terminal triage exit submits a CHANGES_REQUESTED review, so this step has never met a review-less terminal action. Stage 1-pre's duplicate close in feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292 (still open) will be the first — matching the issue's claim.
• Failure mode once it lands: a /triage re-run that closes a PR as duplicate then posts the stage=rerun-summary note — "completed without a new review … If this re-run was meant to review or approve, it did not" — on that same closed PR, and emits ::warning title=Triage re-run left no bot review, dispatching a human to a correctly-handled run. The other review-less shapes (deferred approve-on-green, Stage 1b re-run escalation) don't close the PR, so they stay unaffected.
• Fix direction: in the notify step, fetch state + closedAt (gh pr view "$NUMBER" --json state,closedAt) before warning, and exit quietly (or post an adapted note) when the PR closed at/after the trigger comment. Shape-agnostic — it also covers a maintainer closing the PR mid-run — so it can land before feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292. Precedent already exists in the family: qwen-triage-finalize.yml's stale path treats a closed PR as terminal. The existing pin at scripts/tests/qwen-triage-workflow.test.js:375 should grow an assertion covering the close-exit exemption.

中文说明

• 类型: bug
• 标签: type/bug, category/development, scope/ci-cd, priority/P2
• 下一步: 让 Notify silent triage re-run 步骤感知 PR 关闭；该检查与形态无关，可先于 feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292 合入

分析

• 复现：静态确认（无人值守 CI 不执行工作流代码，无实际运行复现）。.github/workflows/qwen-triage.yml 中的 Notify silent triage re-run 步骤仅凭评审列表判断 —— HAS_REVIEW（触发评论之后机器人是否发过评审）与 STANDING（机器人在当前 head 上的评审），完全没有读取 PR 自身的 state/closedAt。
• 在 feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292 合入前是潜在问题：当前 main 上所有 triage 终止路径都会提交 CHANGES_REQUESTED 评审，该步骤从未遇到过"无评审的终止动作"。feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292（仍 open）中 Stage 1-pre 的重复关闭将是第一个 —— 与 issue 的描述一致。
• 合入后的故障形态：/triage 重跑把 PR 作为重复关闭后，会在同一个已关闭的 PR 上发 stage=rerun-summary 评论 —— "completed without a new review … If this re-run was meant to review or approve, it did not" —— 并输出 ::warning title=Triage re-run left no bot review，把人力派到一次本就正确处理了的运行上。其他无评审形态（延迟 approve-on-green、Stage 1b 重跑升级）不会关闭 PR，不受影响。
• 修复方向：在告警前获取 state + closedAt（gh pr view "$NUMBER" --json state,closedAt），若 PR 在触发评论之时或之后关闭，则静默退出（或发一条适配说明）。该检查与具体形态无关 —— 也覆盖维护者在运行中途手动关闭 PR 的情况 —— 因此可先于 feat(triage): add duplicate / already-fixed gate (Stage 1-pre) #10292 合入。同族已有先例：qwen-triage-finalize.yml 的 stale 分支已把关闭的 PR 视为终止。scripts/tests/qwen-triage-workflow.test.js:375 对该步骤已有固定测试，应补一条覆盖关闭豁免的断言。

--- Qwen Code

[yiliang114]

Reproduced. Extracted the Notify silent triage re-run step body verbatim and drove it with a stubbed gh in the Stage 1-pre close-exit shape (PR closed after the trigger comment, empty review list):

• POSTs the stage=rerun-summary comment ("Triage re-run completed without a new review … If this re-run was meant to review or approve, it did not") on the same PR the run just closed;
• emits ::warning title=Triage re-run left no bot review.

Both come from the review-list-only decision (HAS_REVIEW/STANDING) — nothing reads the PR's own state/closedAt, so the step cannot tell a terminal close from a re-run that did nothing.

Fix incoming: in the notify step, read gh pr view "$NUMBER" --repo "$REPO" --json state,closedAt and treat a close at/after the trigger comment as the terminal action — exit quietly, no summary, no warning. A close before the trigger keeps today's notify behavior. Tests land alongside the existing pin in scripts/tests/qwen-triage-workflow.test.js.