Skip to content

Compatible with version 3 vue and fix before version bugs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compatible with version 3 vue and fix before version bugs #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ripple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var Ripple = {
bind: function(el, binding){
beforeMount: function(el, binding){

// Default values.
var props = {
Expand Down Expand Up @@ -105,6 +105,8 @@ var Ripple = {
}, 850);

el.removeEventListener('mouseup', clearRipple, false);
el.removeEventListener('mouseleave', clearRipple, false);
el.removeEventListener('dragstart', clearRipple, false);

// After removing event set position to target to it's original one
// Timeout it's needed to avoid jerky effect of ripple jumping out parent target
Expand All @@ -130,6 +132,8 @@ var Ripple = {

if(event.type === 'mousedown') {
el.addEventListener('mouseup', clearRipple, false);
el.addEventListener('mouseleave', clearRipple, false);
el.addEventListener('dragstart', clearRipple, false);
} else {
clearRipple();
}
Expand Down