feat: Support large zip files#3118
Conversation
|
Thanks for the PR, is it possible to use https://docs.rs/zip/latest/zip/write/struct.ZipWriter.html#method.set_auto_large_file? |
|
We could do that 👍 only risk is that the consumer of the wheel does not support zip64. Both pip and uv support it, but I don't know about all package registries for example. |
|
I think it only enables zip64 when the compression size exceeds normal zip size so it's safe to enable. |
|
Sorry I think the point I was trying to make is that if the consumer of the wheel (e.g. uv, pip, whatever registry) does not support unzipping zip64, then your wheel is unusable. Perhaps it's better to have a flag when building the wheel to decide whether you want to take that risk or not. Anyways, I'm fine with going forward with auto-enable zip64. All consumers I checked do support it. |
|
Great, let's use |
|
Actually it doesn't seem like the ZipWriter::set_auto_large_file doesn't work? It only changes whether a 64b data descriptor is written: see zip-rs/zip2#468. |
|
You are right, guess this is good middle ground. |
Exposes zip's large file support through a new cli arg
--compression-enable-large-file-support. This supports use cases where the zip's content is larger than 4GB.Looks like the readmes where not up to date, so the diff is a bit larger than just the compression option.