Skip to content

Update zip to 8.1#3039

Merged
messense merged 2 commits into
PyO3:mainfrom
musicinmybrain:zip8
Feb 24, 2026
Merged

Update zip to 8.1#3039
messense merged 2 commits into
PyO3:mainfrom
musicinmybrain:zip8

Conversation

@musicinmybrain

Copy link
Copy Markdown
Contributor

Deal with removal of deprecated DateTime methods, zip-rs/zip2#597. I think I’ve handled these sensibly, but review would be appreciated.

Deal with removal of deprecated `DateTime` methods,
zip-rs/zip2#597.
@messense messense requested a review from Copilot February 24, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the zip dependency from version 6.0.0 to 8.1.0 and addresses breaking changes related to deprecated DateTime methods. The changes handle the removal of timezone-aware datetime constructors in favor of primitive datetime types.

Changes:

  • Updated zip dependency version in Cargo.toml
  • Replaced OffsetDateTime with PrimitiveDateTime throughout the codebase
  • Modified datetime construction to remove timezone specifications

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Updated zip dependency from version 6.0.0 to 8.1.0
tests/run.rs Removed UTC timezone specification from datetime macro call
tests/common/other.rs Changed type signatures and imports from OffsetDateTime to PrimitiveDateTime
src/build_context.rs Added conversion step from OffsetDateTime to PrimitiveDateTime when parsing SOURCE_DATE_EPOCH

Comment thread src/build_context.rs
@messense messense enabled auto-merge (squash) February 24, 2026 13:46
@messense messense merged commit acad35d into PyO3:main Feb 24, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants