Update zip to 8.1#3039
Merged
Merged
Conversation
Deal with removal of deprecated `DateTime` methods, zip-rs/zip2#597.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the zip dependency from version 6.0.0 to 8.1.0 and addresses breaking changes related to deprecated DateTime methods. The changes handle the removal of timezone-aware datetime constructors in favor of primitive datetime types.
Changes:
- Updated
zipdependency version inCargo.toml - Replaced
OffsetDateTimewithPrimitiveDateTimethroughout the codebase - Modified datetime construction to remove timezone specifications
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updated zip dependency from version 6.0.0 to 8.1.0 |
| tests/run.rs | Removed UTC timezone specification from datetime macro call |
| tests/common/other.rs | Changed type signatures and imports from OffsetDateTime to PrimitiveDateTime |
| src/build_context.rs | Added conversion step from OffsetDateTime to PrimitiveDateTime when parsing SOURCE_DATE_EPOCH |
messense
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deal with removal of deprecated
DateTimemethods, zip-rs/zip2#597. I think I’ve handled these sensibly, but review would be appreciated.