Skip to content

Add missing exc argument to PathError #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Add missing exc argument to PathError #474

merged 2 commits into from
Mar 27, 2021

Conversation

althonos
Copy link
Member

Type of changes

  • Bug fix

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

fs.errors.PathError was missing an exc argument, so it couldn't be used in fs.error_tools.convert_os_errors. This prevented the conversion of OSError(errno.ENAMETOOLONG) errors to PathError. Closes #453.

@althonos althonos added the bug label Mar 27, 2021
@althonos althonos added this to the v2.4.13 milestone Mar 27, 2021
@coveralls
Copy link

coveralls commented Mar 27, 2021

Coverage Status

Coverage increased (+0.0009%) to 95.363% when pulling eebb4a2 on fix-patherror into 60b0a63 on master.

@althonos althonos merged commit b88f432 into master Mar 27, 2021
@althonos althonos deleted the fix-patherror branch March 27, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_os_errors error when converting errno.ENAMETOOLONG to PathError
2 participants