Skip to content

Require FS.openbin to return a file-handle with in binary mode #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

althonos
Copy link
Member

Type of changes

  • Bug fix
  • Tests

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

  • Add a test for openbin method in FSTestCases ensuring the returned object has a mode attribute containing the "b" flag.
  • Fix FTPFS.openbin not implicitly converting mode to binary mode. Closes ftpfs possible issue with openbin #406 .
  • Add missing mode attribute to _MemoryFile objects created by MemoryFS.openbin.

@althonos althonos changed the title Openbin mode Require FS.openbin to return a file-handle with in binary mode Oct 13, 2020
@althonos althonos added the bug label Oct 13, 2020
@althonos althonos requested review from lurch and willmcgugan and removed request for lurch October 13, 2020 12:47
Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@althonos althonos added this to the v2.4.12 milestone Oct 13, 2020
@althonos althonos merged commit 526438d into master Oct 13, 2020
@althonos althonos deleted the openbin-mode branch October 13, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ftpfs possible issue with openbin
2 participants