[MemFS] Release memory when close() is called #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested changes
Jul 25, 2019
| posixpath.join(parent_dir, str(file_id)), UNICODE_TEXT | ||
| ) | ||
|
|
||
| @unittest.skipIf( |
lurch
reviewed
Jul 25, 2019
|
I know the contributors list is supposed to be sorted alphabetically but do I really need to put my name at the top? Feels weird. |
|
@dargueta It's cool. The idea was that the order doesn't indicate significance of contribution. PR looks good BTW, thanks. I'll give it another review soon. |
willmcgugan
approved these changes
Jul 28, 2019
|
Thanks |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
MemFS now immediately releases the memory used up by its files when
close()is called, rather than when the file system gets garbage collected. Closes #308 .