Skip to content

Detect __eq__ and __ne__ methods that use Any instead of object #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

Detect __eq__ and __ne__ methods that use Any instead of object #163

merged 2 commits into from
Jan 31, 2022

Conversation

AlexWaygood
Copy link
Collaborator

@AlexWaygood AlexWaygood commented Jan 29, 2022 •
edited
Loading

Closes #138

@AlexWaygood
Copy link
Collaborator Author

AlexWaygood commented Jan 29, 2022 •
edited
Loading

From what I can see, the typeshed-primer output is all true positives except for three entries: the boto and polib hits.

@AlexWaygood AlexWaygood mentioned this pull request Jan 29, 2022
Merged
@AlexWaygood
Copy link
Collaborator Author

typeshed PR here: python/typeshed#7081

@AlexWaygood AlexWaygood changed the title Detect __eq__ and __ne__ that use Any instead of object Detect __eq__ and __ne__ methods that use Any instead of object Jan 29, 2022
@AlexWaygood AlexWaygood reopened this Jan 29, 2022
@Akuli Akuli merged commit 9ef0fe6 into PyCQA:master Jan 31, 2022
@AlexWaygood AlexWaygood deleted the equality branch January 31, 2022 09:20
@AlexWaygood AlexWaygood mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
type-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect Any in __eq__/__ne__
2 participants
@AlexWaygood @Akuli