Fix: PublicKey.KeyIdString must return a valid key id #269
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PublicKey.KeyIdString previously did not compute the key ID correctly for v5 and v6 keys. This commit fixes the issue by directly using the stored key ID from the struct.
twiss
approved these changes
Feb 3, 2025
twiss
approved these changes
Feb 3, 2025
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Feb 28, 2025
…068) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/ProtonMail/go-crypto](https://github.com/ProtonMail/go-crypto) | require | patch | `v1.1.5` -> `v1.1.6` | --- ### Release Notes <details> <summary>ProtonMail/go-crypto (github.com/ProtonMail/go-crypto)</summary> ### [`v1.1.6`](https://github.com/ProtonMail/go-crypto/releases/tag/v1.1.6) [Compare Source](ProtonMail/go-crypto@v1.1.5...v1.1.6) #### What's Changed - Fix `PublicKey.KeyIdString` to return a valid key id by [@​lubux](https://github.com/lubux) in ProtonMail/go-crypto#269 - Allow Key Flags override [@​davrux](https://github.com/davrux) in ProtonMail/go-crypto#272 - Only check that message signatures are newer than the key by [@​twiss](https://github.com/twiss) in ProtonMail/go-crypto#275 - openpgp/clearsign: just use rand.Reader in tests by [@​mdosch](https://github.com/mdosch) in ProtonMail/go-crypto#276 - Make Issuer Key ID signature subpacket non-critical by [@​caarlos0](https://github.com/caarlos0) in ProtonMail/go-crypto#266 - v2 API: Improve error messages for encryption key selection by [@​lubux](https://github.com/lubux) in ProtonMail/go-crypto#271 **Full Changelog**: ProtonMail/go-crypto@v1.1.5...v1.1.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzguMSIsInVwZGF0ZWRJblZlciI6IjM5LjE3OC4xIiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7068 Reviewed-by: Gusted <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublicKey.KeyIdString()previously did not compute the key ID correctly for v5 and v6 keys.This PR fixes the issue by directly using the stored key ID from the struct.