Mystify Foundations #515
Mystify Foundations #515
Conversation
Recent updates
Set default shell
Update to newly mystified cookbook workflows
Fix the workflows
Remove jupyter-book 1 cruft
Myst style toc
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Remove sphinx stuff from env
fix trailing line
Foundations needs different BASE_URL settings
brian-rose
requested review from
dopplershift,
jukent,
r-ford and
dcamron
and removed request for
a team
|
There are still some cosmetic issues to be fixed, such as some duplicated chapter titles (projectpythia-mystmd/cookbook-template#41) and poorly formatted images. Also I haven't really tested any of the interactive components and binder links. My preference is to get this merged and open issues to track (and fix) those remaining issues. |
| children: | ||
| - file: appendix/how-to-contribute.md | ||
| children: | ||
| - file: appendix/template.ipynb |
There was a problem hiding this comment.
Do we not need the jupyter: binder: repo: section?
As you say, approving this so we can merge, let it build, and then continue to iterate if need be.
There was a problem hiding this comment.
Yes probably! Although I'm still hoping there's a way to abstract that away upstream to the pythia_config. I will try out and debug the interactive components tomorrow.
This PR updates the Foundations repo to build with MyST.