Skip to content

2432 Add RandCropByLabelClasses transform #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 13, 2021
Merged

2432 Add RandCropByLabelClasses transform #2557

merged 18 commits into from
Jul 13, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 8, 2021 •
edited
Loading

Fixes #2432 #2560 .

Description

This PR added the RandCropByLabelClasses transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@madil90
Copy link
Contributor

madil90 commented Jul 8, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Jul 8, 2021

/build

1 similar comment
@madil90
Copy link
Contributor

madil90 commented Jul 8, 2021

/build

This was referenced Jul 11, 2021
Closed
Open
@Nic-Ma Nic-Ma changed the title [WIP] 2432 Add RandCropByClassesRatio transform 2432 Add RandCropByLabelClasses transform Jul 12, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 12, 2021 06:18
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 12, 2021

/black

@Nic-Ma Nic-Ma requested review from rijobro, wyli and ericspod July 12, 2021 06:19
wyli
wyli reviewed Jul 12, 2021
View reviewed changes
wyli
wyli reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I have some minor comments

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 13, 2021

Hi @wyli ,

Thanks for your review.
I updated the PR according to your comments.
Could you please help review it again?

Thanks in advance.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 13, 2021

/black

@Nic-Ma Nic-Ma requested a review from wyli July 13, 2021 02:52
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 13, 2021

/black

wyli
wyli reviewed Jul 13, 2021
View reviewed changes
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 13, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 13, 2021 10:06
@Nic-Ma Nic-Ma merged commit 2cb1efc into Project-MONAI:dev Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support to set pos/neg crop ratio for every class
3 participants
@Nic-Ma @madil90 @wyli