Ensure Previewers popup is visible across themes #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I kinda forgot this isn't prism-themes, so I'm not sure if I need to run |
RunDevelopment
approved these changes
Sep 15, 2021
Member
|
Thank you for contributing @hoonweiting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some themes set a positive z-index for some of their parts, such as the
.tokens in Twilight. This makes the Previewers popup appear underneath the code, which is silly. This PR sets a higher z-index for the popup itself (10), so theme creators can still play around with z-index in their themes, without obscuring the popup if the Previewers plugin were to be used.This closes #3074.