Skip to content

1170 Part 2 - 3D specialization for chunk_elements #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 1170-accessor
Choose a base branch
from
Open

1170 Part 2 - 3D specialization for chunk_elements #1223

wants to merge 1 commit into from

Conversation

icui
Copy link
Collaborator

@icui icui commented Sep 18, 2025

Description

  • Add dimension check for gradient and divergence
  • Add 3D specialization for chunk elements.

Issue Number

Adds to #1170

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui icui changed the base branch from main to 1170-accessor September 18, 2025 13:59
Copilot
Copilot AI reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

lsawade
lsawade approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rohit-Kakodkar
Rohit-Kakodkar approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lsawade lsawade lsawade approved these changes

@Rohit-Kakodkar Rohit-Kakodkar Rohit-Kakodkar approved these changes

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icui @lsawade @Rohit-Kakodkar