Issue 1211 - Implements 3D receiver IO and IO tests for receivers #1215
Conversation
| specfem::utilities::is_close(this->x, other.x) && | ||
| specfem::utilities::is_close(this->z, other.z) && | ||
| specfem::utilities::is_close(this->angle, other.angle); | ||
| } |
There was a problem hiding this comment.
Can 2 receivers have same station and network name but have different locations/angle? Should this be a assert?
There was a problem hiding this comment.
This is really only used for checking the read-in stations in the unit tests, I'm not sure whether there is a different use case. If you just want to check whether receivers share the same station name or just the same location, the approach should be slightly different maybe implementing a new a method like same_code(other) or same_location(other)
We could implement a function that weeds out potential duplicates, or throws an error if a vector of receivers contains two receivers of the same angle and location.
There was a problem hiding this comment.
No I am wondering we should throw a runtime error if stations have same name but different location/angle. It's more to do with symantics of operator==. For example, what would be the expected behavior when someone uses the function outside of test.
There was a problem hiding this comment.
Oh, understood! Yes i agree.
| bool specfem::receivers::receiver<specfem::dimension::type::dim3>::operator==( | ||
| const receiver &other) const { | ||
| return (this->network_name == other.network_name) && | ||
| (this->station_name == other.station_name) && | ||
| specfem::utilities::is_close(this->x, other.x) && | ||
| specfem::utilities::is_close(this->y, other.y) && | ||
| specfem::utilities::is_close(this->z, other.z); | ||
| } |
There was a problem hiding this comment.
Same comment as 2D
Description
This PR
io/sourcestests to include source file and yaml node reading.read_receivers->read_2d_receiversread_3d_receiversSTATIONSfile reading and yaml node reading for receiversIssue Number
Closes #1211
Checklist
Please make sure to check developer documentation on specfem docs.