Skip to content

Conversation

Rohit-Kakodkar
Copy link
Collaborator

Description

@int-ptr-ptr I added a skeleton for the non-conforming kernel, which we can fill out after we have the containers. Can you see if this looks right?

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@Rohit-Kakodkar Rohit-Kakodkar linked an issue Sep 12, 2025 that may be closed by this pull request
1 task
Base automatically changed from issue-1172 to issue-1150 September 16, 2025 15:24
Copy link
Collaborator

@int-ptr-ptr int-ptr-ptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, but I do wonder about the future, where coupled interfaces have shared computations (for example, jump operators), so it would be faster to accelerate both self and other at the same time.

Since interfaces are $O(N)$ with the length scale resolution, this won't be an issue for Ivy's problem (we can swallow the unoptimized code for now), but it would be something to keep in mind.

Base automatically changed from issue-1150 to devel September 19, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement kokkos kernel for non-conforming interfaces
2 participants