Iterators and Access functions for edges #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Adds chunk edge iterator - [x] Adds tests for chunk edge iterator - [x] Adds edge intersection iterator - [x] Adds tests for edge intersection iterator - [x] Adds access functions for chunk field
int-ptr-ptr
approved these changes
Aug 29, 2025
Comment on lines
252
to
263
| case specfem::mesh_entity::type::bottom: | ||
| return { ispec, 0, ipoint }; | ||
| break; | ||
| case specfem::mesh_entity::type::top: | ||
| return { ispec, num_points - 1, num_points - 1 - ipoint }; | ||
| break; | ||
| case specfem::mesh_entity::type::left: | ||
| return { ispec, ipoint, 0 }; | ||
| break; | ||
| case specfem::mesh_entity::type::right: | ||
| return { ispec, num_points - 1 - ipoint, num_points - 1 }; | ||
| break; |
There was a problem hiding this comment.
break statement's aren't needed after a return, no?
Also, I guess this type of (edgetype, ipoint) -> (iz, ix) mapping is fine absent weird element orientations since L/R and T/B are switched, but wouldn't you want to stick to strict clockwise or counterclockwise? What we have right now is
←
┌───┐
↑│ n │↓
└───┘
→
which would require no flipping (orientation reversal) for 90 degrees:
→ ←
┌───┐ ┌───┐
↓│ ᴝ │↑↑│ n │↓
└───┘ └───┘
← →
but 180 will always need to be flipped. If instead we stuck to clockwise or counterclockwise, the coupled iterator could handle the ipoint flipping, since orientation reversal will always occur, killing the need for the edge.reverse_orientation.
lsawade
approved these changes
Sep 2, 2025
| EdgeIteratorTestParams{ 1024, | ||
| "ExactChunkSizeEdgeValues" })); | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P( |
| "initialize_edges", | ||
| Kokkos::RangePolicy<Kokkos::DefaultExecutionSpace>(0, number_of_edges), | ||
| KOKKOS_CLASS_LAMBDA(const int i) { | ||
| for (int j = 0; j < num_points; ++j) |
This was
linked to
issues
Sep 2, 2025
|
#1160 may fix unit-test |
- [x] Added `ENUM_ID` to enable strong type checking when checking tags within `FOR_EACH` macro. The macro `_CHECK_ENUM` performs the strong type checking when comparting 2 enums. - [x] Added edge definition macros to enable all types of edges
- [x] Updates mesh containers to hold connecting edges - [x] Adds weakly conforming connection to represent coupled interfaces - [x] Updates mesh reader - [x] Adds edge types container to sort edges for kernel computation
icui
approved these changes
Sep 8, 2025
Create edge types to sort all edges with tags
Refactor `FOR_EACH` macro to incorporate interface tags
- [x] Updates coupled interfaces struct - [x] Adds several new point types (point edge index, point interface index, point coupled interface) - [x] Adds coupled interfaces 2 container which will replace current coupled interface container
- [x] New compute coupling kokkos kernel using ChunkEdgePolicy - [x] Media specific compute coupling (elastic-acoustic & acoustic-elastic) - [x] Adds unit-tests
Reimplement coupled interfaces using macros
Implements new kokkos kernel to compute coupling
- [x] Remove old coupled interfaces implementation - [x] Applied dirichlet boundary conditions
Update compute coupling calls
Co-authored-by: Lucas Sawade <[email protected]>
Co-authored-by: Lucas Sawade <[email protected]>
This reverts commit 55d2717.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.