Issue 990 assembly sources - Implement assembly sources #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function and I have too much uncommited work
Rohit-Kakodkar
approved these changes
Aug 26, 2025
core/specfem/assembly/compute_source_array/dim3/impl/compute_source_array_from_tensor.cpp
Show resolved
Hide resolved
core/specfem/assembly/compute_source_array/dim3/impl/compute_source_array_from_tensor.hpp
Show resolved
Hide resolved
Comment on lines
20
to
27
| // EXTENT_IMPL_CHANGE | ||
| template <typename T, int Rank> struct ExtentImpl { | ||
| using type = typename ExtentImpl<T, Rank - 1>::type *; | ||
| }; | ||
|
|
||
| template <typename T> struct ExtentImpl<T, 0> { | ||
| using type = T; | ||
| }; |
There was a problem hiding this comment.
This needs to be in an impl namespace or a tpp file.
There was a problem hiding this comment.
Will try to use kokkos extents which should be supported from 4.7.00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.