fix: handle pydantic generic models in JSON serializer #19868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes serialization failures when using parameterized Pydantic generic models (e.g.,
APIResult[str]) with the JSON serializer.The Problem
When serializing a parameterized generic like
APIResult[str], the JSON encoder was storing the class name with brackets:{"__class__": "module.APIResult[str]", "data": {...}}This causes deserialization to fail because Python's import system cannot import
APIResult[str]- onlyAPIResult.The Fix
Extract the origin class from Pydantic's
__pydantic_generic_metadata__when encoding, so the serialized output uses the importable base class:{"__class__": "module.APIResult", "data": {...}}Test plan
test_pydantic_generic_model_roundtrip🤖 Generated with Claude Code