fix: correct docket_url setting path to server.docket.url #19791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting was incorrectly referenced as server.docket_url but the actual path is server.docket.url (nested under ServerDocketSettings). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
zzstoatzz
requested review from
chrisguidry,
cicdw and
desertaxle
as code owners
chrisguidry
approved these changes
Dec 15, 2025
CodSpeed Performance ReportMerging #19791 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_run_all_services()server.docket_urltoserver.docket.urlProblem
The docket PR (#19756) introduced a bug where
server.docket_urlwas referenced, but the actual setting path isserver.docket.url(nested underServerDocketSettings).This causes the background services to crash with:
Test plan
get_current_settings().server.docket.urlreturns the expected value🤖 Generated with Claude Code