feat: convert late_runs service to docket perpetual function #19722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace MarkLateRuns LoopService class with docket perpetual function - Use find-and-flood pattern: monitor_late_runs finds late runs and schedules mark_flow_run_late tasks via docket - Register mark_flow_run_late task function in background_workers.py - Remove MarkLateRuns from base.py service modules - Update tests to test docket task functions directly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CodSpeed Performance ReportMerging #19722 will not alter performanceComparing Summary
|
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
MarkLateRunsLoopService class to docket perpetual functions, following the same pattern established in #19715 and #19719.MarkLateRunsLoopService withmonitor_late_runsperpetual functionmark_flow_run_latetasks via docketChanges
late_runs.py: Convert from LoopService to docket perpetual functionbackground_workers.py: Registermark_flow_run_latetask functionbase.py: Removelate_runsfrom service modulestest_late_runs.py: Update tests to test task functions directlytest_perpetual_services.py: Add test formonitor_late_runsregistrationtest_service_subsets.py: RemoveMarkLateRunsfrom service subset assertionsTest plan
🤖 Generated with Claude Code